modules/Mail.php

[Links]

  Links
     Browse SVN
     SVN Commit log
     Documentation (Wiki)
  Developers
     Taskmanager

Advanced search

[Blueeagle]

I've been working on a bot mail system that allows members and guests to send offline messages to eachother. This is a huge improvement over offline tells.

Features:
 - All registered alts of a player has got access to the same mailbox.
 - Configurable with the new settings module to allow different levels of access to send and read mail. (IE it can be restricted so only leaders/admins may send mail and everyone may read mail sendt or only leaders can read mail but everyone can send mail to them or all but guests can send/recieve and so on)
- Configurable expiration time of read and unread mail
- Conigurable (global) notificaton of unread mail when a player logs on any of his alts

To do: (ignore the to-do list in the Mail.php file.
 - Cron jobs got lost in a brainfart. Needs to be re-implemented.
 - Colors of message windows needs to be ported to the new Colors module
 - Implement a mass messaging feature so that leaders (configurable ofcourse) can send messages to everyone of a certain access level. (Not sure how this should be done. Ideas are welcome)
 - For those running a webserver on the same machine as the bot it would be possible to implement a web-based send mail interface that iterfaces directly with the database. Not sure how to best make such an interface to be implementable by various boards used by guilds tho.
 - Testing, testing and more testing

Please give feedback.

Attatchment: modules/Mail.php

_{Edit: Added more stuff to the TO-DO list}

[Alreadythere]

Nice idea!

For more info on colors check the wiki

[Blueeagle]

Nice idea!

For more info on colors check the wiki

Yeah, I saw that. I had it all set up but I lost it when I was updating the svn tree. :p

[Malosar]

Thats a really good idea, mind if I help out?

[Wolfbiter]

Always thought about doing this, but never got off my fat ass.
Good job.

[Wolfbiter]

Well.. here goes my check of the script...

Code:

Line 186: $mailbox=$this->bot->alts->main($user);
Line 187: $no_of_messages=$this->new_mail_count($name);

I assume it's supposed to use main for mail, but it still checks mail for $name instead of $mailbox.

Maybe make the logon notify a user setting instead of a script setting? Since some people might want to be notified and others doesn't.
For when you add cron, maybe go over buddylist and see if anyone has any unread mail still?
You should remove all commented things that isn't yours (like all the stuff from the template you don't use).

[Blueeagle]

Thats a really good idea, mind if I help out?

Thank you and no, go right a head.

Edit: Khalem talked something about setting up a dev branch. Now I don't know how to do that but it might be a good idea if several people are to be working on this.

[Blueeagle]

Well.. here goes my check of the script...

Code:

Line 186: $mailbox=$this->bot->alts->main($user);
Line 187: $no_of_messages=$this->new_mail_count($name);

I assume it's supposed to use main for mail, but it still checks mail for $name instead of $mailbox.

Maybe make the logon notify a user setting instead of a script setting? Since some people might want to be notified and others doesn't.
For when you add cron, maybe go over buddylist and see if anyone has any unread mail still?
You should remove all commented things that isn't yours (like all the stuff from the template you don't use).

Yeah I think I missed some notifies. This probably explains it. Thank you.

[Alreadythere]

Some errors I caught:

• in mail_send() you have checks to escape the string and replace some stuff. It's working on $mail_message instead of $message though, or the variable in the INSERT should be $mail_message.
• if($settings['Logon_notificaton']=TRUE) in buddy() will always be true
• if(msg===1) in buddy() got one = too many
• I've had to adapt the settings names to the ucfirst(strtolower()) format now used in SVN (I guess you posted the module before I made the change in SVN).

As I don't like spam right on logon I've added a slight delay to the notifies. And I've added default access levels for the commands.

Here is my modified version with the fixes/adds.

PS: forgot to add: if you aren't allowed to send mail it just returns an empty tell. Missing some return value there.

[Blueeagle]

Good job mate!

Just to find something to pick on:

• if(msg===1) in buddy() got one = too many

= assings
== checks for equality
=== checks for identicality

if (1 ==  "1") is true while
if (1 === "1") is false because 1 is an integer while "1" is a string

A moot point since the variable type is irellevant in this case.

[Malosar]

hehe, you said assings 

(sorry, had to do it)

[Alreadythere]

= assings
== checks for equality
=== checks for identicality

if (1 ==  "1") is true while
if (1 === "1") is false because 1 is an integer while "1" is a string

A moot point since the variable type is irellevant in this case.

Didn't know that yet, nice to learn that.

[Blueeagle]

hehe, you said assings 

(sorry, had to do it)

Aw poo!

[Alreadythere]

Why did you add the make_item_blob() function btw? Not sure what's it supposed to archieve, and it's crashing my AORC

[Blueeagle]

Because itemrefs sendt trough make_blob were rendered useless.