collapse collapse
* User Info
 
 
Welcome, Guest. Please login or register.
* Search

* Board Stats
  • stats Total Members: 989
  • stats Total Posts: 18363
  • stats Total Topics: 2500
  • stats Total Categories: 7
  • stats Total Boards: 35
  • stats Most Online: 1144

Author Topic: serious issue in MassMsg module !  (Read 4097 times)

0 Members and 1 Guest are viewing this topic.

Offline bitnykk

  • Administrator
  • ********
  • Posts: 79
  • Karma: +0/-0
serious issue in MassMsg module !
« on: November 13, 2010, 07:56:09 pm »
I discovered and fixed a serious issue that was resulting in huge spams (double message + 10 or more Preflinks) while using !massinv and !announce ...

The issue came from this part of code (line 148 to 153) :
Quote
            $dis = $dis.$blobs[(int)$massmsg][(int)$massinv];
         }
         else
            $dis = "";

         $message = str_ireplace("##disable##", $dis, $msg);

With more than one recipient, the $dis variable would be filled of several times of itself. The fix i made was to use a different var :
Quote
            $addlink = $dis.$blobs[(int)$massmsg][(int)$massinv];
         }
         else
            $addlink = "";

         $message = str_ireplace("##disable##", $addlink, $msg);

Offline Khalem

  • BeBot Founder
  • Administrator
  • ********
  • Posts: 1169
  • Karma: +0/-0
    • http://www.ancarim.com
Re: serious issue in MassMsg module !
« Reply #1 on: November 15, 2010, 04:49:22 pm »
This was already fixed in trunk, but not backported to 0.6

Thanks for the heads up.
BeBot Founder and Fixer Kingpin

Offline bitnykk

  • Administrator
  • ********
  • Posts: 79
  • Karma: +0/-0
Re: serious issue in MassMsg module !
« Reply #2 on: November 16, 2010, 04:06:55 am »
Yaz, that was in the 0.6.8 i took @ launchpad.net from left menu upleft of page here.

Happy to know it's gonna be fixed :)

 

* Recent Posts
[AoC] special char for items module by bitnykk
[February 09, 2024, 09:41:18 pm]


0.8.x updates for AoC by bitnykk
[January 30, 2024, 11:16:08 pm]


0.8.x updates for AO by bitnykk
[January 30, 2024, 11:15:37 pm]


BeBot still alive & kicking ! by bitnykk
[December 17, 2023, 12:58:44 am]


Bebot and Rasberry by bitnykk
[November 29, 2023, 11:04:14 pm]

* Who's Online
  • Dot Guests: 495
  • Dot Hidden: 0
  • Dot Users: 0

There aren't any users online.
* Forum Staff
bitnykk admin bitnykk
Administrator
Khalem admin Khalem
Administrator
WeZoN gmod WeZoN
Global Moderator
SimplePortal 2.3.7 © 2008-2024, SimplePortal