Redundant code in roster.php

Content

Links

Browse SVN

SVN Commit log

Documentation (Wiki)
Developers

Taskmanager

User

Welcome, Guest. Please login or register.
Did you miss your activation email?
December 01, 2008, 12:44:37 PM

BeBot - An Anarchy Online/Age Of Conan chat automaton > Forum > Development > Coding and development discussion > Topic: Redundant code in roster.php

Pages: [1] Go Down

« previous next »

	Author	Topic: Redundant code in roster.php (Read 308 times)
0 Members and 1 Guest are viewing this topic.

MajorOutage

Freshman

Offline

Posts: 3

Redundant code in roster.php

« on: March 29, 2007, 04:12:22 AM »

Whenever you add a member or guest without using the 'add' command, you get both a success msg and an error msg. Also, if you put a command but not a name, you get 2 error messages.

This is caused by lines 102-105 (for member) and 151-154 (for guest) in Modules/Roster.php

Code:

if (empty($vars[2]))
{
$this -> bot -> send_output($source, "You have to provide a character name", $type);
}

This is redundant code, as there are already error handlers in place for each command, and should be removed.


	Logged

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: Redundant code in roster.php

« Reply #1 on: March 29, 2007, 05:17:35 PM »

Not sure if it's redundant or a true bug.

That part of the code is supposed to handle !guest|member [add] name commands, which means the username could be in vars[1] or vars[2].


	Logged

Khalem

BeBot Founder
Administrator
Grandmaster

Offline

Gender: Male

Posts: 670

Re: Redundant code in roster.php

« Reply #2 on: April 06, 2007, 08:28:16 PM »

This is a bug.

Upon the first error you should bail.


	Logged

BeBot Founder and Fixer Kingpin
Madman coder and destroyer of good code

Pages: [1] Go Up

BeBot - An Anarchy Online/Age Of Conan chat automaton > Forum > Development > Coding and development discussion > Topic: Redundant code in roster.php

« previous next »