Bug in Subcommand check

Content

Links

Browse SVN

SVN Commit log

Documentation (Wiki)
Developers

Taskmanager

User

Welcome, Guest. Please login or register.
Did you miss your activation email?
December 02, 2008, 11:51:16 PM

BeBot - An Anarchy Online/Age Of Conan chat automaton > Forum > Support > BeBot 0.5 support > Topic: Bug in Subcommand check

Pages: [1] Go Down

« previous next »

	Author	Topic: Bug in Subcommand check (Read 207 times)
0 Members and 1 Guest are viewing this topic.

Temar

BeBot Developer
Grandmaster

Offline

Gender: Male

Posts: 877

Bug in Subcommand check

« on: February 12, 2008, 09:45:41 PM »

im guessing that $ = NO subcommands allowed

in AccessControl.php function check_rights
it does a Check
if (isset($this -> access_cache[strtolower($command)]['$'][strtolower($channel)]))
IF
if ($subcommand === false)
wat if it isnt false? (which is when it NEEDS it most
i dont see a check

this is all asuming im guessing right about what $ means


	Logged

MSN messenger: chris_smith96 at hotmain dot com
Xfire: chriss96

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: Bug in Subcommand check

« Reply #1 on: February 13, 2008, 06:08:46 AM »

subcommand = "$" in the table means that no parameter or subcommand is allowed for this access right entry. Only !command without any further text is valid. This case only can happen if no subcommand exists, that's why it's in the $subcommand === false branch.

If $subcommand !== false we got a subcommand, so the $ entry cannot be valid anyways. That means we don't need to check for it, as the default behaviour of check_rights() is to return false. Which will happen if no valid subcommand entry for access rights is found.

So no, I think there is no bug here.


	Logged

Blueeagle

Omnipotent
BeBot Developer
Expert

Offline

Gender: Male

Posts: 313

Re: Bug in Subcommand check

« Reply #2 on: February 13, 2008, 10:46:51 AM »

Speaking of sub-commands when you look at any commandline program they use a dash or a slash to mark options. Is this something we should concider?

The syntax would then become something like !member -add Someuser

I am pretty sure that it will make a uniform options handler much easier to implement.

Alternately each module might make an array $subcom[]='add'; $subcom[]='del'; and one could loop trough it. Any thoughts on such an alternate implementation?


	Logged

The only problem that can't be solved by adding another wrapper is having too many wrappers.

Temar

BeBot Developer
Grandmaster

Offline

Gender: Male

Posts: 877

Re: Bug in Subcommand check

« Reply #3 on: February 13, 2008, 10:51:40 AM »

so if some one does more than just command it will get denied because it can't find access level

I don't see any use for it tho as a module that uses command only could just ignor the rest


	Logged

MSN messenger: chris_smith96 at hotmain dot com
Xfire: chriss96

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: Bug in Subcommand check

« Reply #4 on: February 13, 2008, 12:10:28 PM »

Check the !member command. Without any parameter it shows the memberlist, with add/del as parameter is changes it. Some bot admins may want to allow all members to check the memberlist, but in most cases they don't want non-admins to change it. This case can only be handled with something like $.