online is spaming

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: online is spaming

« Reply #15 on: May 03, 2007, 08:37:23 AM »

I can try to add an option to disabled itemref parsing, but no clue if I can add that limiting stuff in there, as my experience in programming for IRC is almost non-existent Wink


	Logged

Nytridr

Expert

Offline

Gender: Male

Posts: 261

Re: online is spaming

« Reply #16 on: May 03, 2007, 02:55:16 PM »

sounds good.. I sent ya a message with my custom IRC file.. you will see it in there.. They are in the gmsg and the privgroup functions.. isnt all that hard.. but with out it if the msg is longer then what IRC will natively accept.. it cuts it off and makes a very bad list of every command used in the script to the max characters allowed by IRC and ends it .. it don't look pretty .. so the only way I could think of doing it was to just stop the really long ones from even being transmitted.

I can give ya access to our org bot if you would like for testing and what not.. if that would help out..also another thing I was thinking is having a verible for IRC color.. and IRC name that is transmitting..

link in the following in function irc_recieve(&$irc, &$data)

Code:

if ($this -> chat <= 1)
$this -> bot -> send_gc($this -> guildprefix . " <font color=#808000>" . $data -> nick . "</font>: " . $msg);
if ($this -> chat >= 1)
$this -> bot -> send_pgroup($this -> guildprefix . " <font color=#808000>" . $data -> nick . "</font>: " . $msg);

have a IRC name in one color varible and the msg in another color varible all done read from the database and changeable without restarting the bot.


	Logged

Co-Prez of Rising Sun RK1 (1st & only org I will ever belong to)

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: online is spaming

« Reply #17 on: May 04, 2007, 04:35:48 AM »

Added your wishes to SVN version.


	Logged

Nytridr

Expert

Offline

Gender: Male

Posts: 261

Re: online is spaming

« Reply #18 on: May 04, 2007, 11:46:03 AM »

Quote from: Alreadythere on May 04, 2007, 04:35:48 AM

Added your wishes to SVN version.

awesome so far so good..one problem is ..

with formating off

Code:

<a href="itemref://218744/218745/198">Spiri-Aid Spindle</a>

that is what is shown in org chat.. it isnt making a link..

with formating on..

Code:

Spiri-Aid Spindle (http://aomainframe.net/showitem.asp?LowID=218744&HiID=218745&QL=198)

so it is working.. kind of.. just not allowing the bot to have it as a link..

in the irc_recieve I had to change the the following two lines to get it to work correctly..

Code:

$msg = str_replace("<", "<", $data -> message);
$msg = str_replace(">", ">", $msg);

and in the gmsg and privgroup I had to

Code:

$msg = str_replace(">", ">", $msg);
$msg = str_replace("<", "<", $msg);

and also the
StripFormatting: Off is actually on.. and the on is actually off..

on does the anuo and aomainframe and off does the item links

and yes I understand the str_replace but I left it in there for illustration.

and good job on the colors.. that was exactly what I wanted.. very nice..

oh one other thing.. if "online" is anywhere in the msg then the IRC file will spit out from every org who is online.. spaming all connected org channels..


« Last Edit: May 04, 2007, 12:19:11 PM by Nytridr »	Logged

Co-Prez of Rising Sun RK1 (1st & only org I will ever belong to)

Vhab

BeBot Contributor
Experienced

Offline

Posts: 158

Re: online is spaming

« Reply #19 on: May 04, 2007, 12:07:47 PM »

Since there's some development going on on the IRC plugin I feel obligated to hint at http://bebot.shadow-realm.org/index.php/topic,707.0.html Tongue


	Logged

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: online is spaming

« Reply #20 on: May 04, 2007, 12:22:59 PM »

What did I do...

But good point, before I go and make some self-defined formatting we should better try to adapt the format you posted there, as it allows quite a bit more versality on all ends.


	Logged

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: online is spaming

« Reply #21 on: May 04, 2007, 12:29:23 PM »

Quote from: Nytridr on May 04, 2007, 11:46:03 AM

and also the
StripFormatting: Off is actually on.. and the on is actually off..

on does the anuo and aomainframe and off does the item links

Uhm it's working as I intended... StripFormatting = TRUE means formatting is stripped. StripFormatting = FALSE means it's put as it is on IRC.

Quote from: Nytridr on May 04, 2007, 11:46:03 AM

oh one other thing.. if "online" is anywhere in the msg then the IRC file will spit out from every org who is online.. spaming all connected org channels..

No clue what's causing that... didn't modify anything past the formatting.


	Logged

Nytridr

Expert

Offline

Gender: Male

Posts: 261

Re: online is spaming

« Reply #22 on: May 04, 2007, 12:32:04 PM »

Quote from: Vhab on May 04, 2007, 12:07:47 PM

Since there's some development going on on the IRC plugin I feel obligated to hint at http://bebot.shadow-realm.org/index.php/topic,707.0.html Tongue

yea this topic has kind of lead from one thing to another.. way of life I suppose..

I totally forgot about that one where I posted what I had.. but so far alreadythere has for the most part already put in almost everything.. just need to work out the little things now. other then that it looks good

Quote

oh one other thing.. if "online" is anywhere in the msg then the IRC file will spit out from every org who is online.. spaming all connected org channels..
No clue what's causing that... didn't modify anything past the formatting.

yea it has always did that since we went to IRC.. but now with the !online being able to show more then 1 org.. its kind of redundant.. well I suppose not really.. but it will spit out by bot who is online if online is anywhere in the message


	Logged

Co-Prez of Rising Sun RK1 (1st & only org I will ever belong to)

Nytridr

Expert

Offline

Gender: Male

Posts: 261

Re: online is spaming

« Reply #23 on: May 06, 2007, 08:16:50 PM »

ummm the bots are back to spamming again.. it dont happen all the time.. and it is very random..


	Logged

Co-Prez of Rising Sun RK1 (1st & only org I will ever belong to)

Nytridr

Expert

Offline

Gender: Male

Posts: 261

Re: online is spaming

« Reply #24 on: May 22, 2007, 01:52:37 PM »

on all 4 bots I am having to run with LogonNotify_GUILD.php as _LogonNotify_GUILD.php since it is still spamming when people log on, sometimes it only sends the !online 2 times but most of the time it is sending it 20+ times.


	Logged

Co-Prez of Rising Sun RK1 (1st & only org I will ever belong to)

Alreadythere

BeBot Maintainer
Administrator
Grandmaster

Offline

Posts: 1085

Re: online is spaming

« Reply #25 on: May 24, 2007, 12:42:41 PM »

Removed LogonNotify_GUILD.php from SVN, as I moved the functionability into the two related modules (News.php and OnlineDisplay.php). The spamming can be enabled via settings.

Should remove the spamming, and I considered LogonNotify_GUILD.php as a hack anyways.


	Logged

Khalem

BeBot Founder
Administrator
Grandmaster

Offline

Gender: Male

Posts: 670

Re: online is spaming

« Reply #26 on: June 30, 2007, 06:34:12 PM »

Spamming still occuring with latest SVN.

Something is very weird, and i cant seem to find any obvious place it's broken either.

Seems totally random, poor guildie was just spammed with about 20 Online and 20 News tells.


	Logged

BeBot Founder and Fixer Kingpin
Madman coder and destroyer of good code

Khalem

BeBot Founder
Administrator
Grandmaster

Offline

Gender: Male

Posts: 670

Re: online is spaming

« Reply #27 on: July 02, 2007, 09:19:45 PM »

This should now be fixed in latest SVN.


	Logged

BeBot Founder and Fixer Kingpin
Madman coder and destroyer of good code

Nytridr

Expert

Offline

Gender: Male

Posts: 261

Re: online is spaming

« Reply #28 on: July 03, 2007, 12:52:20 AM »

Quote from: Khalem on July 02, 2007, 09:19:45 PM

This should now be fixed in latest SVN.

Nice.. does this mean I can turn it back on now..

almost scared to even umm ya.. try it


	Logged

Co-Prez of Rising Sun RK1 (1st & only org I will ever belong to)

Khalem

BeBot Founder
Administrator
Grandmaster

Offline

Gender: Male

Posts: 670

Re: online is spaming

« Reply #29 on: July 03, 2007, 08:14:11 AM »

From all my testing so far, it works.

The reason it happened is still baffling though to put it mildly.

Basically, what was happening was that the Logon Notify cron() was called, which in turn calls the 3 modules that are hooked into it, Online, News and Autoinvite.
Now due to the Online taking some time to generate by default with display of access levels, before cron() could finish running, it was called again. The slower things went, the more times cron() could be called. And thats the puzzling part. We dont thread!!! Somehow, cron() kept getting called even though it was not done with it's current iteration which should be impossible unless 1) We are threaded (which we're not), or 2) There are recursive calls (which i cant find any evidence of)

So yeah, baffling.


	Logged

BeBot Founder and Fixer Kingpin
Madman coder and destroyer of good code

Pages: 1 [2] 3 Go Up

BeBot - An Anarchy Online/Age Of Conan chat automaton > Forum > Support > Support for older versions > BeBot 0.3 support > Topic: online is spaming

« previous next »